Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side panel size does not restore on reload #134679

Closed
JacksonKearl opened this issue Oct 8, 2021 · 6 comments
Closed

Side panel size does not restore on reload #134679

JacksonKearl opened this issue Oct 8, 2021 · 6 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Milestone
October 2021

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Oct 8, 2021 •
edited by sbatten

This bug was re-purposed as "I shrink the side panel but that doesn't get preserved on reload. "

The below content is not related to the issue this is tracking

Haven't been able to reproduce without sidebar, pretty consistant (not 100% though) with it.
recording (37)

Bonus bug: I shrink the side panel but that doesn't get preserved on reload.
@JacksonKearl
Copy link
Contributor Author

The back patches following the cursor in that gif aren't the bug, just a git artifact.

@sbatten
Copy link
Member

sbatten commented Oct 9, 2021 •
edited

@JacksonKearl can you use dev tools to inspect that? I'm not sure what it is and I cannot repro.

@sbatten sbatten added the info-needed Issue requires more information from poster label Oct 9, 2021
@gjsjohnmurray
Copy link
Contributor

Is this #134750?

@jeanp413
Copy link
Contributor

@gjsjohnmurray yeah looks like it's the same issue 😄
@sbatten created PR #134752 fixing it

@jeanp413
Copy link
Contributor

#134752 is merged, think we can close this now.

@JacksonKearl
Copy link
Contributor Author

Thanks, I wonder why this wasn't showing up without the side panel for me.

In that case I'll change this issue to be the bonus bug, in which the side panel does not restore its size on reload.

@JacksonKearl JacksonKearl changed the title Side panel causes weird black dot at topleft of editor Side panel size does not restore on reload Oct 11, 2021
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues and removed info-needed Issue requires more information from poster labels Oct 11, 2021
@sbatten sbatten added this to the October 2021 milestone Oct 11, 2021
@bpasero bpasero added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
6 participants
@bpasero @sbatten @gjsjohnmurray @JacksonKearl @jeanp413 and others