Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating peek title info color #134821

Merged
merged 1 commit into from Oct 11, 2021
Merged

Updating peek title info color #134821

merged 1 commit into from Oct 11, 2021

Conversation

lychung7
Copy link
Contributor

@lychung7 lychung7 commented Oct 11, 2021 •
edited

This PR fixes #120920

Removed opacity for light theme peek title info color to meet the 4.5:1 color contrast ratio.
image

miguelsolorio
miguelsolorio approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@miguelsolorio miguelsolorio added this to the October 2021 milestone Oct 11, 2021
@miguelsolorio miguelsolorio merged commit 6cdd384 into microsoft:main Oct 11, 2021
@miguelsolorio miguelsolorio mentioned this pull request Oct 11, 2021
Closed
@lychung7 lychung7 deleted the lychung/peekviewtext branch October 11, 2021 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miguelsolorio miguelsolorio miguelsolorio approved these changes

Assignees

@miguelsolorio miguelsolorio

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lychung7 @miguelsolorio