Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum mismatch in deb package for .desktop files #134839

Closed
timretout opened this issue Oct 11, 2021 · 2 comments · Fixed by #134840
Closed

Checksum mismatch in deb package for .desktop files #134839

timretout opened this issue Oct 11, 2021 · 2 comments · Fixed by #134840
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@timretout
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.61.0-1633631387
  • OS Version: Debian

Steps to Reproduce:

  1. install .deb package
  2. run debsums -s

(This has been previously reported as #37762 and #112311 and I cannot see any way to reopen them.)

The current postinst file calls "desktop-file-install" on the installed desktop files. This has the effect of adding the following line to each file:

X-Desktop-File-Install-Version=0.26

This gets flagged by tools which validate the security of the software supply chain, such as debsums.

In the previous issues it is implied that this tool is called in order to add the .desktop files to the menu immediately; for this there is a dedicated command update-desktop-database which will update the menu cache without modifying the installed files.

@timretout
Copy link
Contributor Author

/verified

After installing the latest code-insiders .deb, debsums no longer flags the .desktop files as changed.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@timretout @Tyriar and others