Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window is frozen with both Java extension and bracketPairColorization enabled #134973

Closed
Eskibear opened this issue Oct 13, 2021 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders semantic-tokens Semantic tokens issues verified Verification succeeded
Milestone

Comments

@Eskibear
Copy link
Member

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: both 1.61-stable and 1.62-insiders
  • OS Version: windows 11

When both a) extension redhat.java is enabled and b) editor.bracketPairColorization.enabled is true, vscode window can be frozen after typing [ in some place, and meanwhile eating CPU and RAM.

Steps to Reproduce:
It's origininally reported in microsoft/vscode-java-pack#764 (comment) with detailed repro steps.

Note that, either disabling redhat.java or bracketPairColorization can work well.

I can also reproduce it by myself:

pairColorizationFreeze.mp4

Above video is recorded with:

Version: 1.62.0-insider (user setup)
Commit: 284e0db6c4cac1e557a43cd6691babdaafc2e1a9
Date: 2021-10-12T05:45:14.621Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000
@hediet hediet added bracket-pair-colorization bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues semantic-tokens Semantic tokens issues labels Oct 14, 2021
@hediet hediet added this to the October 2021 milestone Oct 14, 2021
@alexdima alexdima self-assigned this Oct 22, 2021
@alexdima
Copy link
Member

Here are the encoded semantic tokens I see at runtime for this file:

// deltaLine, deltaCharacter, length, tokenTypeIndex, tokenModifierSet
0, 13, 16, 1, 80,
1, 2, 6, 11, 0,
0, 7, 6, 11, 0,
0, 15, 8, 7, 82,
0, 17, 1, 10, 16,
0, 7, 5, 10, 16,
1, 12, 8, 9, 16,
0, 19, 5, 10, 0,
0, 7, 1, 1, 0,
0, 4294967294, 5, 12, 0

FYI @Eskibear It looks like the last one is malformed, which ends up triggering a bug with us.

@Eskibear
Copy link
Member Author

Thank you for your effort on this. I can reproduce that Java Language server is reporting a broken token 0, -2, 5, 12, 0, which should be fixed.

@roblourens roblourens added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders semantic-tokens Semantic tokens issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@roblourens @Eskibear @hediet @alexdima and others