Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for deprecated messages in the settings ui #135044

Merged
merged 1 commit into from Oct 13, 2021

Conversation

miguelsolorio
Copy link
Contributor

This PR fixes #135043 and adds an error icon to the deprecated message:

CleanShot 2021-10-13 at 14 58 38@2x

Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@miguelsolorio miguelsolorio merged commit 20e692d into main Oct 13, 2021
@miguelsolorio miguelsolorio deleted the misolori/settings-deprecated branch October 13, 2021 23:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated message in settings ui should use an icon
3 participants