Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #128602 by adjusting the line when the previous line is also cut. #135089

Merged
merged 2 commits into from Oct 15, 2021
Merged

Fixes #128602 by adjusting the line when the previous line is also cut. #135089

merged 2 commits into from Oct 15, 2021

Conversation

hediet
Copy link
Member

@hediet hediet commented Oct 14, 2021

This PR fixes #128602

@hediet hediet requested a review from alexdima October 14, 2021 14:38
alexdima
alexdima approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pushed a test.

@alexdima alexdima added this to the October 2021 milestone Oct 15, 2021
@alexdima alexdima merged commit 7c61ce5 into main Oct 15, 2021
@alexdima alexdima deleted the hediet/cut-last-line-mulitcursor branch October 15, 2021 07:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@hediet hediet

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

When cutting multiple lines (ctrl x), the last line will not be erased
2 participants
@hediet @alexdima