Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover font does not inherit editor's font family and font weight #135102

Closed
dreambit opened this issue Oct 14, 2021 · 4 comments
Closed

Hover font does not inherit editor's font family and font weight #135102

dreambit opened this issue Oct 14, 2021 · 4 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2021

Comments

@dreambit
Copy link

image

After update to 1.61 hover font does not inherit editor's font-family and font-weight
@alexdima
Copy link
Member

@dreambit I cannot observe any change between 1.60.2 and 1.61.0:

1.60.2:

image

1.61.1:

image

@alexdima alexdima self-assigned this Oct 15, 2021
@alexdima alexdima added editor-hover Editor mouse hover info-needed Issue requires more information from poster labels Oct 15, 2021
@dreambit
Copy link
Author

@alexdima Could you make your editor's font weight bold and check hover's font weight? Thanks

@dreambit
Copy link
Author

image

as you can see I have font-weight - bold and before 1.61 font-weight in the hover was also bold

@alexdima
Copy link
Member

Thank you for the extra information, I can reproduce, with "editor.fontWeight": "bold", starting with 1.61 the source code rendered in the hover is no longer bold:

1.60.2

image

1.61.1

image

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Oct 18, 2021
@alexdima alexdima added this to the October 2021 milestone Oct 18, 2021
@lramos15 lramos15 added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
4 participants
@dreambit @lramos15 @alexdima and others