Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backticks from word character fix #135197

Merged
merged 3 commits into from Oct 27, 2021
Merged

Remove backticks from word character fix #135197

merged 3 commits into from Oct 27, 2021

Conversation

thebinarysearchtree
Copy link
Contributor

@thebinarysearchtree thebinarysearchtree commented Oct 16, 2021

This PR fixes #61070. Backticks were not supposed to be part of the fix for #25658 and adding them in creates issues with tagged templates in JavaScript and TypeScript.

@alexdima alexdima self-assigned this Oct 17, 2021
@alexdima alexdima added this to the October 2021 milestone Oct 17, 2021
@alexdima alexdima added the editor-autoclosing Editor automatic closing of parens / brackets / etc. label Oct 27, 2021
@alexdima
Copy link
Member

Thank you!

@thebinarysearchtree
Copy link
Contributor Author

thebinarysearchtree commented Oct 28, 2021

@alexdima This pr does not fix #132912. I have created another pr to fix that. If you use it, you may want to change the name of isNotStart because I don't even know what that is checking so didn't know what to call it.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-autoclosing Editor automatic closing of parens / brackets / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backticks not auto-closing for tagged template literals
2 participants