Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff view: Notebooks output marked in green and red when no changes observed #135424

Closed
ronglums opened this issue Oct 19, 2021 · 0 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@ronglums
Copy link

ronglums commented Oct 19, 2021

Version: 1.62.0-insider (user setup)
Commit: 34eeebd
Date: 2021-10-15T05:16:57.817Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

Steps to Reproduce:

  1. Open this notebook file in VS Code: https://github.com/claudiaregio/data-science/blob/main/Titanic.ipynb
  2. Add a new cell at the end of the file and run it.
  3. Switch to SCM sidebar and open the notebook diff view.

Expected: no output is highlighted in green or red color except for the newly added cell.
Actual: Output that's marked as unchanged show in green and red color. for example:
image

for reference: video recording of the issue https://msit.microsoftstream.com/video/77870840-98dc-948e-5cfa-f1ec309ecd3a (starting 20'15'')

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority diff-editor Diff editor mode issues labels Oct 19, 2021
@rebornix rebornix added this to the October 2021 milestone Oct 20, 2021
@roblourens roblourens added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor mode issues important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @rebornix @ronglums and others