Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable replacePattern #135444

Merged
merged 1 commit into from Oct 21, 2021
Merged

Enable replacePattern #135444

merged 1 commit into from Oct 21, 2021

Conversation

j824h
Copy link
Contributor

@j824h j824h commented Oct 20, 2021 •
edited

This PR fixes #135264

By interpreting the Replace input as replacePattern when "Use Regular Expression", replacing with capturing group is enabled.
This makes the find-and-replace behavior more consistent between Jupyter and the normal editor.

@ghost
Copy link

ghost commented Oct 20, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@j824h j824h marked this pull request as ready for review October 20, 2021 03:35
@rebornix rebornix merged commit a1bc3f5 into microsoft:main Oct 21, 2021
@rebornix
Copy link
Member

@j824h thanks for your contribution, it's really awesome!

@j824h j824h deleted the j824h/issue135264 branch October 24, 2021 01:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jupyter find and replace with capturing groups
2 participants
@j824h @rebornix