Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored MainThreadAuth with silent option and tests #135503

Merged
merged 1 commit into from
Oct 20, 2021
Merged

refactored MainThreadAuth with silent option and tests #135503

merged 1 commit into from
Oct 20, 2021

Conversation

TylerLeonhardt
Copy link
Member

This PR adds:

  • a silent option that will replace the hasSession API
  • a large refactor of mainThreadAuthentication's logic for getting a session
  • tests!!

@TylerLeonhardt TylerLeonhardt merged commit c71e201 into main Oct 20, 2021
@TylerLeonhardt TylerLeonhardt deleted the TylerLeonhardt/refactored-mainthread-auth branch October 20, 2021 19:17
@gjsjohnmurray gjsjohnmurray mentioned this pull request Nov 21, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@TylerLeonhardt