Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.MD preview text is not updated when the README.MD file is replaced within the VSCODE explorer #135568

Closed
pa0694 opened this issue Oct 21, 2021 · 6 comments
Closed

README.MD preview text is not updated when the README.MD file is replaced within the VSCODE explorer #135568

pa0694 opened this issue Oct 21, 2021 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues *out-of-scope Posted issue is not in scope of VS Code verification-found Issue verification failed
Milestone
On Deck

Comments

@pa0694
Copy link

pa0694 commented Oct 21, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.61.2
  • OS Version: Windows 10

Steps to Reproduce:

  1. Add a README.MD file with some text to the root folder
  2. Preview the file in VSCode and close the preview
  3. Create an other README.MD inside an other folder, and then drag & drop it to the Explorer tab in VSCode in order to erase the previous README.MD (it's important to do drag and drop it from the explorer in VSCode and not in Windows Explorer)
  4. Preview the README.MD in VSCode : it's the previous README.MD which is showed, and not the current one (bug)
    capture
@mjbvz mjbvz added the markdown Markdown support issues label Oct 22, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Oct 22, 2021

@jrieken It looks like onDidChangeTextDocument is not fired in this case. Is this expected? Is there a different event I should listen to?

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Oct 22, 2021
@jrieken
Copy link
Member

jrieken commented Oct 22, 2021

@bpasero should know for sure. Maybe a replace triggers close and open events?

@bpasero
Copy link
Member

bpasero commented Oct 22, 2021

Yes, it should be close and open because the file is replaced, so the model is first disposed and then recreated.

@mjbvz mjbvz added this to the November 2021 milestone Nov 2, 2021
@mjbvz mjbvz closed this as completed in 97e646c Nov 3, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 1, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Dec 1, 2021

Closing the second file before dragging it over sometimes results in the first file just closing, too.
I can repro this case fairly consistently, though I did hit the correct/expected behaviour once.

Recording

@rzhao271 rzhao271 reopened this Dec 1, 2021
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Dec 1, 2021
@mjbvz mjbvz modified the milestones: November 2021, December 2021 Dec 6, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Jan 24, 2022

@bpasero Can you please take a look at this? Following @rzhao271's comment, I confirmed this is not a markdown specific problem

@mjbvz mjbvz modified the milestones: January 2022, On Deck Jan 24, 2022
@mjbvz mjbvz assigned bpasero and unassigned mjbvz Jan 24, 2022
@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues *out-of-scope Posted issue is not in scope of VS Code verification-found Issue verification failed
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
6 participants
@bpasero @jrieken @rzhao271 @mjbvz @pa0694 and others