Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mock-debug a yeoman generator, publish /common as NPM module #1356

Closed
felixfbecker opened this issue Dec 15, 2015 · 4 comments
Closed
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@felixfbecker
Copy link
Contributor

The whole process of cloning mock-debug to make a debugger extension and then changing it is cumbersome. Like for normal extensions, there should be a yeoman generator that asks you questions about what languages the debugger is for, what the name should be etc.

Secondly, in the docs you express the intent to move the common part of the mock-debug repo to a NPM module, which makes sense, as it's the TS implementation of the debugger protocol so we can write extensions in TS using it. You would be able to add more features over time etc.

I think this would make writing debugger extensions more straight forward.

@dbaeumer dbaeumer added feature-request Request for new features or functionality bug Issue identified by VS Code Team member as probable bug labels Dec 16, 2015
@dbaeumer dbaeumer added this to the Backlog milestone Dec 16, 2015
@weinand weinand removed the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2015
@weinand
Copy link
Contributor

weinand commented Dec 16, 2015

@felixfbecker a first cut of the npm modules is available as vscode-debugprotocol and vscode-debugadapter. The corresponding github repo will be made pulic soon.

@felixfbecker
Copy link
Contributor Author

@weinand a little weird having an npm module just for the protocol .d.ts. Maybe this should rather be put to DefiniatelyTyped? And is a yeoman generator planned?

@weinand
Copy link
Contributor

weinand commented Dec 16, 2015

@felixfbecker as I said, this is a first cut. We might want to add more to the vscode-debugprotocol module.

We don't want to use DefinitelyTyped for this because we need the strong version support of npm.

Yes, a yeoman generator for an empty debugadapter is planned but first we had to refactor the code because we don't want to have the generator generate lots of duplicated code (and I'm a bit reluctant with the yeoman generator in general because node based debug-adapters implemented in TypeScript are not as frequently created as VSCode extensions in general).

BTW, I just made Microsoft/vscode-debugadapter-node public.

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 16, 2015
@weinand
Copy link
Contributor

weinand commented Dec 16, 2015

This issue was moved to microsoft/vscode-mock-debug#2

@weinand weinand closed this as completed Dec 16, 2015
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants