make checked optional on IAction to differentiate false from never checked #135605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
approved these changes
Oct 22, 2021
|
@sbatten thanks a lot for fixing this, the changes look great 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #120597
The problem that I'm trying to solve is that menu entries are controlled by
IActionand those only allow forcheckedto betrueorfalse. However, whencheckedisfalse, we don't know if it could ever betruewhich makes it impossible set the appropriate aria labels.Sending this through PR because while the solution works, I am spanning display vs model logic and this might not be the preferred approach.