Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webviews do not work in built server #135641

Closed
alexdima opened this issue Oct 22, 2021 · 4 comments
Closed

Webviews do not work in built server #135641

alexdima opened this issue Oct 22, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

alexdima commented Oct 22, 2021

  • run e.g. yarn run gulp vscode-reh-web-darwin
  • launch ./vscode-reh-web-darwin/server.sh
  • open in web and try to preview a markdown file
  • observe error:

image

NOTE: I think the problem is related to an assumption that the bits are available at a certain URL

image

@mjbvz mjbvz added this to the October 2021 milestone Oct 25, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Oct 25, 2021

The root cause of this seems to be that product.commit is set to the current git commit. This means that we try pulling the webview bits from a CDN commit that doesn't exist

The standard oss builds don't set product.commit so not sure if the OSS server needs to

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Oct 25, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Oct 25, 2021

Looks like commit is set in these files:

https://github.com/microsoft/vscode/blob/42a0825e8ee30dc942adac00467200a8aa2f93a1/build/gulpfile.reh.js

const commit = util.getVersion(REPO_ROOT);

Hardcoding commit fixes the issue but I think this will break our normal builds

@mjbvz mjbvz closed this as completed in 1100001 Oct 25, 2021
@alexr00
Copy link
Member

alexr00 commented Oct 26, 2021

Needed to revert 1100001 to unblock the build, so reopening this issue.

@alexr00 alexr00 reopened this Oct 26, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Oct 27, 2021

Found the issue and reverted with bc566d4

@mjbvz mjbvz closed this as completed Oct 27, 2021
@lramos15 lramos15 added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@lramos15 @alexdima @mjbvz @alexr00 and others