Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize capitilization of "Go to" #135869

Merged
merged 1 commit into from Oct 27, 2021
Merged

Standardize capitilization of "Go to" #135869

merged 1 commit into from Oct 27, 2021

Conversation

jakevossen5
Copy link
Contributor

If you type Go to into the command pallet, the debug examples are the only ones with a capital To, this should fix that

@ghost
Copy link

ghost commented Oct 26, 2021 •
edited by ghost

CLA assistant check
All CLA requirements met.

@weinand
Copy link
Contributor

weinand commented Oct 27, 2021

@alexdima I'm not sure that we want to change "Go To" to "Go to".
VS uses "Go To", Xcode uses "Go to".
What do you think?

@alexdima
Copy link
Member

The path of least resistance here seems to be to use the lower-case variant i.e. Go to. That is only by looking at the amount of actions using the lower-case vs the upper-case variant:

image
image

So I would suggest that we go with the lower-case variant, as proposed here.

@alexdima alexdima requested a review from weinand October 27, 2021 14:08
weinand
weinand approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@weinand weinand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexdima alexdima requested a review from jrieken October 27, 2021 14:31
@jrieken jrieken merged commit e4c3b31 into microsoft:main Oct 27, 2021
@jrieken jrieken added this to the October 2021 milestone Oct 27, 2021
@jrieken
Copy link
Member

jrieken commented Oct 27, 2021

Thanks @jakevossen5

@gregvanl gregvanl changed the title Standardize captilization of "Go to" Standardize capitilization of "Go to" Nov 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

@weinand weinand weinand approved these changes

@alexdima alexdima alexdima approved these changes

Assignees

@jrieken jrieken

@weinand weinand

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
October 2021
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakevossen5 @weinand @alexdima @jrieken