Migrate docker workspace tags to configfiles #135993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
requested changes
Oct 28, 2021
| { tag: 'github-actions', filePattern: /^.+\.yml$/i, relativePathPattern: /^\.github(?:\/|\\)workflows$/i } | ||
| { tag: 'github-actions', filePattern: /^.+\.yml$/i, relativePathPattern: /^\.github(?:\/|\\)workflows$/i }, | ||
| { tag: 'devcontainer.json', filePattern: /^devcontainer\.json$/i }, | ||
| { tag: 'dockerfile', filePattern: /^(dockerfile|docker\-compose\.ya?ml)$/i } |
There was a problem hiding this comment.
Dockerfiles are often uppercase which this doesn't work on. It doesn't look like they make the paths or file names lowercase before testing. Maybe we should just so we're casing agnostic
There was a problem hiding this comment.
But the /i makes the expression match case-insensitive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes more sense and I wasn't aware when I added the new tags.