Moves bracket logic from text model into BracketPairsImpl (IBracketPairs) #136024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexdima This PR moves all the old bracket pair matching logic into the new IBracketPair interface (and BracketPairImpl class).
The idea is to organize the various aspects of the TextModel into separate classes/interface.
This causes a circular dependency (BracketPairImpl depends on TextModel which depends on BracketPairImpl), but I think that is ok (as long as
BracketPairImpldoes not accesstextModel.bracketPairs).Maybe in the future this could be improved by having some CoreTextModel that just provides the editing experience and the TextModel that composes the CoreTextModel, Tokenization, IBracketPairs and so on.