Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape unicode directional formatting characters when rendering control characters #136347

Merged
merged 1 commit into from Nov 3, 2021

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Nov 3, 2021

Fixes #116939

This also changes the default for editor.renderControlCharacters to be true by default. Here is how things will look by default for the directional formatting characters:


transferBalance(5678,‮6776,4321‬,"USD");

image

…rendering control characters. Also turn on `editor.renderControlCharacters` by default.
@alexdima alexdima requested a review from hediet November 3, 2021 11:58
@alexdima alexdima added this to the October 2021 milestone Nov 3, 2021
@alexdima alexdima merged commit b3318bc into release/1.62 Nov 3, 2021
@alexdima alexdima deleted the alex/116939 branch November 3, 2021 13:00
@alexdima alexdima self-assigned this Nov 3, 2021
@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Nov 3, 2021
@aeschli aeschli added the verified Verification succeeded label Nov 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants