Browse themes to install in the color theme picker #136371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandy081 FYI the changes to src/vs/workbench/services/extensionResourceLoader/electron-sandbox/extensionResourceLoaderService.ts as discussed a while ago. |
sandy081
reviewed
Nov 3, 2021
| private _getExtensionResourceAuthority(uri: URI): string | undefined { | ||
| const index = uri.authority.indexOf('.'); | ||
| return index !== -1 ? uri.authority.substring(index + 1) : undefined; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we somehow reuse this in both services (browser & electron-sandbox) versions, instead of duplicating?
There was a problem hiding this comment.
Yes. I would make a proposal for that in a follow-up PR, if that's ok. I think it's probably best done in a abstract base class for the ExtensionResourceLoaderService
Thanks, that's perfect (and the intent) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.