Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable find widget for webviews on web #136473

Closed
mjbvz opened this issue Nov 4, 2021 · 2 comments
Closed

Enable find widget for webviews on web #136473

mjbvz opened this issue Nov 4, 2021 · 2 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2021

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 4, 2021

Tracks enabling the find widget inside webviews for web versions of VS Code

We can use window.find for this
@mjbvz mjbvz added the feature-request Request for new features or functionality label Nov 4, 2021
@mjbvz mjbvz added this to the November 2021 milestone Nov 4, 2021
@mjbvz mjbvz self-assigned this Nov 4, 2021
@mjbvz mjbvz closed this as completed in 8e3bfab Nov 5, 2021
@mjbvz mjbvz mentioned this issue Nov 19, 2021
Closed
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Nov 29, 2021
@jrieken jrieken added the verified Verification succeeded label Nov 30, 2021
@jrieken
Copy link
Member

jrieken commented Nov 30, 2021

Verified but I believe @rzhao271 did something similar (for electron) which I remember is working better

@rzhao271
Copy link
Contributor

The web and Electron implementations rely on very different APIs for now.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
4 participants
@jrieken @rzhao271 @mjbvz and others