Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bracket pair colorization: horizontal guides within bracket pairs on the same line #136475

Closed
aplotor opened this issue Nov 5, 2021 · 6 comments
Assignees
Labels
bracket-pair-guides feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@aplotor
Copy link

aplotor commented Nov 5, 2021

request: show horizontal guides within bracket pairs on the same line, like CoenraadS's Bracket Pair Colorizer 2 does::
image

default::
image

@hediet hediet added bracket-pair-guides feature-request Request for new features or functionality labels Nov 5, 2021
@hediet
Copy link
Member

hediet commented Nov 5, 2021

Should this always happen or just for wrapped lines?

We explicitly don't render horizontal guides when the opening and closing bracket are on the same line.

@hediet hediet added this to the Backlog milestone Nov 5, 2021
@aplotor
Copy link
Author

aplotor commented Nov 5, 2021

i'd prefer it to always happen, it is helpful for wrapped lines and for clarity of nested brackets on the same line. if some people dont like it they could turn it off.

@danFromTelAviv
Copy link

is there an expectation for when this might make it in?
this seems like a super awesome feature!!

@hediet
Copy link
Member

hediet commented Apr 1, 2022

Next insiders build will support this:

image

@hediet hediet closed this as completed in 78cb0b4 Apr 1, 2022
@joyceerhl joyceerhl added the verification-needed Verification of issue is requested label Apr 25, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bracket-pair-guides feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@hediet @rzhao271 @joyceerhl @aplotor @danFromTelAviv and others