Debug: Clicking a callstack row calls openEditor twice

[bpasero]

Add a console.log(new Error().stack) into

vscode/src/vs/workbench/contrib/debug/common/debugSource.ts

Line 75 in 4ed0329

openInEditor(editorService: IEditorService, selection: IRange, preserveFocus?: boolean, sideBySide?: boolean, pinned?: boolean): Promise<IEditorPane | undefined> {

Follow steps from #136684 (comment). Notice how openEditor is called 2 times:

debugSource.js:53 Error
    at Source.openInEditor (debugSource.js:53)
    at StackFrame.openInEditor (debugModel.js:322)
    at DebugService.focusStackFrame (debugService.js:691)
    at focusStackFrame (callStackView.js:214)
    at callStackView.js:222
    at Emitter.fire (event.js:435)
    at TreeResourceNavigator._open (listService.js:494)
    at TreeResourceNavigator.onPointer (listService.js:472)
    at listService.js:438
    at Emitter.fire (event.js:435)
    at event.js:43
    at Emitter.fire (event.js:435)
    at event.js:43
    at Emitter.fire (event.js:435)
    at TreeNodeListMouseController.onViewPointer (listWidget.js:535)
    at TreeNodeListMouseController.onViewPointer (abstractTree.js:852)
    at event.js:65
    at Emitter.fire (event.js:435)
    at event.js:43
    at Emitter.fire (event.js:435)
    at HTMLDivElement.fn (event.js:11)
debugSource.js:53 Error
    at Source.openInEditor (debugSource.js:53)
    at StackFrame.openInEditor (debugModel.js:322)
    at callStackView.js:223
    at Emitter.fire (event.js:435)
    at TreeResourceNavigator._open (listService.js:494)
    at TreeResourceNavigator.onPointer (listService.js:472)
    at listService.js:438
    at Emitter.fire (event.js:435)
    at event.js:43
    at Emitter.fire (event.js:435)
    at event.js:43
    at Emitter.fire (event.js:435)
    at TreeNodeListMouseController.onViewPointer (listWidget.js:535)
    at TreeNodeListMouseController.onViewPointer (abstractTree.js:852)
    at event.js:65
    at Emitter.fire (event.js:435)
    at event.js:43
    at Emitter.fire (event.js:435)
    at HTMLDivElement.fn (event.js:11)

[joaomoreno]

Sorry for the delay here. The problem isn't in the list widget but in the call stack view, which does two things simultaneously to open the file:

vscode/src/vs/workbench/contrib/debug/browser/callStackView.ts

Lines 311 to 312 in c6e58d1

	focusStackFrame(element, element.thread, element.thread.session);
	element.openInEditor(this.editorService, e.editorOptions.preserveFocus, e.sideBySide, e.editorOptions.pinned);

@roblourens Am I right in assigning this to you now?