Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toggleTerminal command randomly fails sometimes #137360

Closed
Tyriar opened this issue Nov 17, 2021 · 4 comments · Fixed by #137079
Closed

toggleTerminal command randomly fails sometimes #137360

Tyriar opened this issue Nov 17, 2021 · 4 comments · Fixed by #137079
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues workbench-views Workbench view issues
Milestone
November 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 17, 2021

recording

Likely fix as this was reproducible in smoke tests: 9371d14

cc @sbatten
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues workbench-views Workbench view issues labels Nov 17, 2021
@Tyriar Tyriar added this to the November 2021 milestone Nov 17, 2021
@Tyriar Tyriar mentioned this issue Nov 17, 2021
Merged
@alexr00
Copy link
Member

alexr00 commented Dec 3, 2021

What is the best way to verify this?

@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Dec 3, 2021
@meganrogge
Copy link
Contributor

@alexr00 run the smoketests on webkit

@meganrogge meganrogge removed the verification-steps-needed Steps to verify are needed for verification label Dec 3, 2021
@alexr00
Copy link
Member

alexr00 commented Dec 3, 2021

Looks like the webkit smoketests all fail on Windows. Leaving for someone else to verify.

@Tyriar
Copy link
Member Author

Tyriar commented Dec 6, 2021

This is actually still an issue in #137514, closing in favor of that since there are more details.

@Tyriar Tyriar reopened this Dec 6, 2021
@Tyriar Tyriar closed this as completed Dec 6, 2021
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues workbench-views Workbench view issues
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Add terminal profile smoke tests microsoft/vscode
4 participants
@Tyriar @meganrogge @alexr00 and others