DIsplay Select Kernel in kernel picker
#137380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
kernelPickerFixesAgain
branch
2 times, most recently
from
91969e0
to
1f086dc
Compare
DonJayamanne
commented
Nov 17, 2021
| @@ -64,7 +64,7 @@ export class NotebooKernelActionViewItem extends ActionViewItem { | |||
| private _updateActionFromKernelInfo(info: INotebookKernelMatchResult): void { | |||
|
|
|||
| this._action.enabled = true; | |||
| const selectedOrSuggested = info.selected ?? info.suggestions[0]; | |||
| const selectedOrSuggested = info.selected ?? (info.all.length === 1 && info.suggestions.length === 1 ? info.suggestions[0] : undefined); | |||
There was a problem hiding this comment.
This was missing, users would get prompted to select a kernel but kernel picker would not read Select Kernel without this change.
rchiodo
approved these changes
Nov 17, 2021
IanMatthewHuff
approved these changes
Nov 17, 2021
DonJayamanne
force-pushed
the
kernelPickerFixesAgain
branch
from
1f086dc
to
cc7a0a6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.