Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 16: Integration test fails to start on mac when loading spdlog #137431

Closed
deepak1556 opened this issue Nov 18, 2021 · 5 comments
Closed
Assignees
Labels
electron-16-update Issues related to electron 16 update integration-test-failure macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone

Comments

@deepak1556
Copy link
Contributor

Refs #137241

Currently the issue is only seen in CI runs, haven't been able to repro the issue locally.

 Module did not self-register: '/Users/runner/work/vscode/vscode/node_modules/spdlog/build/Release/spdlog.node'

The error means that spdlog is trying to be loaded more than once in the same process when it is not context aware and currently the error is triggered from the main process.

    at createSpdLogLogger (/Users/runner/work/vscode/vscode/out/vs/platform/log/node/spdlogLog.js:12:35)
    at SpdLogLogger._createSpdLogLogger (/Users/runner/work/vscode/vscode/out/vs/platform/log/node/spdlogLog.js:63:34)
    at new SpdLogLogger (/Users/runner/work/vscode/vscode/out/vs/platform/log/node/spdlogLog.js:53:48)
    at /Users/runner/work/vscode/vscode/out/vs/code/electron-main/main.js:56:47
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async CodeMain.startup (/Users/runner/work/vscode/vscode/out/vs/code/electron-main/main.js:43:17)
@deepak1556 deepak1556 self-assigned this Nov 18, 2021
@deepak1556 deepak1556 added electron-16-update Issues related to electron 16 update integration-test-failure macos Issues with VS Code on MAC/OS X labels Nov 18, 2021
@bpasero bpasero self-assigned this Nov 18, 2021
@bpasero bpasero added this to the November 2021 milestone Nov 18, 2021
@bpasero bpasero added this to ✨ New in Electron Integration Nov 18, 2021
@bpasero bpasero moved this from ✨ New to 🏃 In Progress in Electron Integration Nov 18, 2021
@bpasero
Copy link
Member

bpasero commented Nov 18, 2021

Seeing this:

The module '/Users/bpasero/Development/Microsoft/vscode-electron-16.x/node_modules/spdlog/build/Release/spdlog.node'
was compiled against a different Node.js version using
NODE_MODULE_VERSION 93. This version of Node.js requires
NODE_MODULE_VERSION 99. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).

@deepak1556
Copy link
Contributor Author

Version 99 is Electron 16 and Version 93 is Node 16 , so looks like the headers and libraries were downloaded incorrectly not based on the .yarnrc. Lets try deleting your node-gyp cache.

@bpasero
Copy link
Member

bpasero commented Nov 18, 2021

👍 , how to?

@deepak1556
Copy link
Contributor Author

rm -rf ~/Library/Caches/node-gyp/16.0.0

@deepak1556
Copy link
Contributor Author

Fixed in ae4ddcd

@bpasero bpasero added the verified Verification succeeded label Nov 18, 2021
@bpasero bpasero moved this from 🏃 In Progress to ✔️ Done / Deferred in Electron Integration Dec 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron-16-update Issues related to electron 16 update integration-test-failure macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
Archived in project
Electron Integration
  
✔️ Done / Deferred
Development

No branches or pull requests

2 participants