Fix missing active debug line + breakpoint glyph #137471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves microsoft#137436. When multiple classes (e.g. codicon-debug-breakpoint,codicon-debug-hint) are added they would disable the ::after content for consecutive classes for the HTML Element. This patch adds a parent element to the overlay and adds all classes as seperated divs, so they can be drawn on top of each other.
|
Thanks, but do you happen to know why it broke? |
|
I think my commit 49efe65 broke it. Maybe it is the rule I think it would be easier to add that rule back instead of the fix suggested by this PR. |
added 2 commits
November 19, 2021 11:32
This path reverts the previous change of wrapping each class in a parent div.
This readds a content-element for codicons which was removed in 49efe65. The content applies when both the classes `codicon-debug-breakpoint and `codicon-debug-stackframe`.
|
Thank you! |
|
@hediet I think that might be the case. Because the content of Reverted in the last commits. Works like a charm.
|
|
Maybe edit the PR title to reflect what it ended up doing? |
roblourens
changed the title
weinand
added
the
debug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves #137436.
When multiple classes (e.g. codicon-debug-breakpoint,codicon-debug-hint)
are added they would disable the ::after content for consecutive classes
for the HTML Element.
This patch adds a parent element to the overlay and adds all classes as
seperated divs, so they can be drawn on top of each other.
This PR fixes #137436.