Shows a banner if a file has too many highlighted unicode characters. #137889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hediet
commented
Nov 25, 2021
•
hediet
commented
hediet
force-pushed
the
hediet/unicode-highlighting-banner
branch
from
4df5d26
to
74bc6aa
Compare
hediet
force-pushed
the
hediet/unicode-highlighting-banner
branch
from
74bc6aa
to
433b97d
Compare
alexdima
approved these changes
Nov 26, 2021
| @@ -458,6 +458,7 @@ export abstract class CommonEditorConfiguration extends Disposable implements IC | |||
|
|
|||
| protected abstract readConfiguration(styling: BareFontInfo): FontInfo; | |||
|
|
|||
| public abstract reserveHeight(height: number): void; | |||
There was a problem hiding this comment.
Now I realize that this method could be implemented here because it doesn't need any dom stuff (it can live in /common/ here). _computeInternalOptions could then subtract the reserved height.
alexdima
reviewed
Nov 26, 2021
| @@ -424,6 +516,78 @@ const DECORATION = ModelDecorationOptions.register({ | |||
| } | |||
| }); | |||
|
|
|||
| export class DisableHighlightingOfAmbiguousCharactersAction extends EditorAction { | |||
| public static ID = 'editor.action.unicodeHighlight.disableHighlightingOfAmbiguousCharacters'; | |||
| public readonly shortLabel = nls.localize('unicodeHighlight.disableHighlightingOfAmbiguousCharacters.shortLabel', ''); | |||
There was a problem hiding this comment.
It looks like shortLabel here is gettting removed by the tree shaking. The reason is that if you try to find all references or rename this property, you will notice that no references are found by TypeScript, or that the rename introduces a compilation error.
The solution is to be more explicit (instead of relying 100% on duck-typing) and create a new interface IDisableUnicodeHighlightAction with the shortLabel property and then explicitly implement it.
hediet
force-pushed
the
hediet/unicode-highlighting-banner
branch
from
256eae8
to
8a305e1
Compare
guibber
pushed a commit
to guibber/vscode
that referenced
this pull request
Nov 30, 2021
…hlighting-banner Shows a banner if a file has too many highlighted unicode characters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.