Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move telemetry cleansing into shared process #138323

Open
jrieken opened this issue Dec 2, 2021 · 2 comments
Open

Move telemetry cleansing into shared process #138323

jrieken opened this issue Dec 2, 2021 · 2 comments
Assignees
Labels
debt Code quality issues telemetry Telemetry system issues
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 2, 2021

Follow up from #138153

We do a bunch of cleansing operations so that we lower the chances to accidentally leak PII or any other sensible data to telemetry. This currently happens in the renderer process and therefore can impact performance, esp. startup performance. I also don't know how/if we clean telemetry from other processes, like the main process. Since telemetry is send from the shared process we should do the cleansing there so that even mistakes don't impact startup performance

@lramos15
Copy link
Member

lramos15 commented Dec 2, 2021

Yeah this is a bit more of a complicated refactor which is why we steered away from it. The render processor implements the common telemetry service which is implemented pretty much everywhere telemetry is sent. This is required because some things like workbench common properties are unique to the renderer. The "sending" in the shared process is just all the data already formed and cleaned being sent over IPC and then directly to app insights.

@jrieken
Copy link
Member Author

jrieken commented Dec 2, 2021

Yeah, I understand that's nothing for November but generally this should be relatively easy, right? Cleaning is done with a bunch of regular expression and if those can only be created with the renderer help it should be easy to send them over to the shared process, right?

@lramos15 lramos15 added telemetry Telemetry system issues debt Code quality issues labels Dec 2, 2021
@lramos15 lramos15 added this to the On Deck milestone Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues telemetry Telemetry system issues
Projects
None yet
Development

No branches or pull requests

3 participants