Unable to yarn install with VS2022 build tools

[JJRcop]

Does this issue occur when all extensions are disabled?: N/A

• VS Code Version: main @ 470cee7
• OS Version: Windows 10 Home 21H1 19043.1348 Windows Feature Experience Pack 120.2212.3920.0

Steps to Reproduce:

1. Don't have Visual Studio 2019 installed anywhere
2. Install prerequisites including Node.js but don't install native c++ build tools
3. Install Visual Studio Build Tools 2022 separately
4. Attempt to run yarn install

Result:

Receive error from build\npm\preinstall.js:

Invalid C/C++ Compiler Toolchain. Please check https://github.com/microsoft/vscode/wiki/How-to-Contribute#prerequisites.

This is because Visual Studio Build Tools 2022 installs to C:\Program Files (x86)\Microsoft Visual Studio\2022, but build\npm\preinstall.js does not consider 2022 to be a supported version, only 2019 and 2017.

vscode/build/npm/preinstall.js

Line 48 in 5f63d72

const supportedVersions = ['2019', '2017'];

I would prefer to save disk space and avoid installing Visual Studio Build Tools 2019 when I already have 2022 installed.

[joaomoreno]

Forwarding it to @deepak1556 in case he'd like to update our docs to include 2022 as well. Otherwise, we close it.

[deepak1556]

I haven't tested with 2022 yet, @JJRcop is rest of the yarn step successful after bypassing the preinstall step ?

[JJRcop]

Adding '2022' to the supportedVersions array works with node-gyp version v8.4.0 or later. When I made this issue, I was on v8.3.9, where it didn't work.

Upgrading node-gyp to v8.4.1 fixed install, and yarn install works without issue on VS2022.

https://github.com/nodejs/node-gyp/releases/tag/v8.4.0

So, yes.

[deepak1556]

Thanks for testing, given that this requires node-gyp >=8.4.0 which also brings in nodejs/node-gyp@a27dc08, it won't build the native modules on the main branch correctly due to older electron version. We can add 2022 to the list once #137241 lands.

[deepak1556]

@JJRcop main branch is now updated to Electron 16, do you want to send a PR to add 2022 to the supported list ? Thanks!