Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find regex error overlaps window #139667

Open
jsoref opened this issue Dec 23, 2021 · 0 comments
Open

Find regex error overlaps window #139667

jsoref opened this issue Dec 23, 2021 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations

Comments

@jsoref
Copy link
Contributor

jsoref commented Dec 23, 2021

Issue Type: Bug

  1. Open the find box
  2. Select the regular expression option (.*)
  3. Paste this:

https?://(?:(?:www.|)youtube.com|youtu.be)/(?:channel/|embed/|playlist?list=|watch?v=|v/|)[-a-zA-Z0-9?&=]|<\syoutube\s+id=['"][-a-zA-Z0-9?]['"]img.youtube.com/vi/[-a-zA-Z0-9?&=]*google-analytics.com/collect.[-0-9a-zA-Z?%=&.~]googleapis.com/[a-z]+/v\d+/[a-z]+/[@./?=\w]+[-a-zA-Z0-9.]storage\d.googleapis.com(?:/\S|)calendar.google.com/calendar(?:/u/\d+|)/embed?src=[@./?=\w&%]+|\w+@group.calendar.google.codatastudio.google.com/(?:(?:c/|)u/\d+/|)(?:embed/|)(?:open|reporting|datasources|s)/[-0-9a-zA-Z]+(?:/page/[-0-9a-zA-Z]+|)|/docs.google.com/[a-z]+/d/(?:e/|)[0-9a-zA-Z_-]+/?(?:edit?[-\w=#.]|)drive.google.com/file/d/[0-9a-zA-Z_?=]groups.google.com/(?:forum/#!|d/)(?:msg|topic)/[^/]+/[a-zA-Z0-9]+(?:/[a-zA-Z0-9]+|)|themes.googleusercontent.com/static/fonts/[^/]+/v\d+/[^.]+.clients2.google(?:usercontent|).com[-0-9a-zA-Z/.]|/goo.gl/[a-zA-Z0-9]+chrome.google.com/webstore/detail/\w(?:/\w*|)books.google.(?:\w{2,4})/books?[-\w\d=&#.]fonts.(?:googleapis|gstatic).com/[-/?=:;+&0-9a-zA-Z]accounts.google.com/[-_/?=.:;+%&0-9a-zA-Z]|/archives/list/[^@/]+@[^/]/message/[^/]/[0-9a-fA-F]{8}-(?:[0-9a-fA-F]{4}-){3}[0-9a-fA-F]{12|pkg:github/[^/]/[^/](?:@|/commit/)[0-9a-f]ID: [0-9a-f]{40|ADD file:[0-9a-f]{64|sha256[-:][0-9a-f]{64|(['"])[0-9a-f]{64}\g{-1}|"sha512": "[0-9a-f]{128}"|"(?:dev.(?:cosignproject|sigstore).cosign/signature|\Qdev.cosign.signature.baseimage\E)": "[-a-zA-Z=;:/0-9+]"|"sig": "[0-9a-f]*"([A-Za-z])\g{-1}{3,}

(Yes, it's a generated pattern, no one would normally write this pattern by hand, but hey.)

Actual results:
image

Expected results:

  1. The red error box shouldn't run over the macOS gems
  2. Perhaps make the box wider and either entirely below the find box or entirely above it instead of to its left (and overlapping!)
  3. The actual error portion of the message should be visible -- if that means cropping the user data, that's totally fine, encouraged even!

Technical details:
It's probably the perlre \Q / \E that's upsetting VSCode, but that's entirely irrelevant, I'm only interested in the presentation of the error, not the cause of the error

VS Code version: Code 1.63.2 (899d46d, 2021-12-15T09:37:28.172Z)
OS version: Darwin x64 20.6.0
Restricted Mode: Yes

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 56, 42, 20
Memory (System) 16.00GB (0.24GB free)
Process Argv --crash-reporter-id 8313cd45-1683-4d50-8d14-e201658944cd
Screen Reader no
VM 0%
Extensions (1)
Extension Author (truncated) Version
vscode-yaml red 1.2.2
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30384386
pythondataviewer:30285071
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30410667
vscop804cf:30404767
vscop940:30404999
vsrem710:30416614
vscexrecpromp3t1:30407762

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations labels Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-find Editor find operations
Projects
None yet
Development

No branches or pull requests

2 participants