Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow Search #14012

Closed
una opened this issue Oct 19, 2016 · 11 comments
Closed

Slow Search #14012

una opened this issue Oct 19, 2016 · 11 comments
Assignees
Labels
search Search widget and operation issues
Milestone

Comments

@una
Copy link

una commented Oct 19, 2016

  • VSCode Version: Code 1.6.0 (e52fb0b, 2016-10-10T18:28:55.412Z)
  • OS Version: Darwin x64 15.4.0
  • Extensions: HookyQR.beautify-0.4.1, anseki.vscode-color-0.1.11, christian-kohler.path-intellisense-1.1.0, dbaeumer.vscode-eslint-1.0.8, donjayamanne.githistory-0.1.0, ms-vscode.js-atom-grammar-0.1.10, robertohuertasm.vscode-icons-3.0.5, seanmcbreen.Spell-0.8.6, streetsidesoftware.code-spell-checker-0.10.13, zhuangtongfa.Material-theme-1.0.3

Steps to Reproduce:

  1. Open a large file system
  2. Search across the system

I love this product, but the only downside of it (which can be prohibitive when doing certain types of work) is how slow the search is when searching across the file system. Not sure if its a plugin I have installed, but searching in Sublime Text is relatively speedy (for comparison), while searching through VS Code seems to take a long time and never complete the search.

@roblourens
Copy link
Member

roblourens commented Oct 19, 2016

To be clear, do you mean full text search like with cmd+shift+f, or searching for a file by name with cmd+p? Could you check if it's any faster without extensions, by launching with --disable-extensions from the command line?

@roblourens
Copy link
Member

And roughly how large is the folder that you open?

@una
Copy link
Author

una commented Oct 19, 2016

cmd+shift+f ! Thanks for clarifying

@roblourens roblourens added the search Search widget and operation issues label Oct 19, 2016
@una
Copy link
Author

una commented Oct 19, 2016

Maybe it was a plugin, it does seem to go faster without extensions and with a system refresh. It was pretty painful before

@andreiropotica
Copy link

Same problem here, very slow search... I have several plugins but that shuldn't afect the search...

  • VSCode Version: Code 1.6.1 (9e4e44c, 2016-10-13T16:21:53.542Z)
  • OS Version: Windows_NT ia32 6.3.9600
  • Extensions: cmstead.jsrefactor-0.5.3, dbaeumer.jshint-0.10.15, dbalage.vscode-stylesheet-formatter-0.2.0, donjayamanne.githistory-0.1.0, donjayamanne.jquerysnippets-0.0.1, HookyQR.JSDocTagComplete-0.0.2, mohsen1.prettify-json-0.0.3, ms-vscode.jscs-0.1.9, msjsdiag.debugger-for-chrome-1.2.2, shinnn.stylelint-0.17.3, stevencl.addDocComments-0.0.8, Tyriar.sort-lines-1.1.0, waderyan.gitblame-1.3.0, wcwhitehead.bootstrap-3-snippets-0.0.7

@roblourens
Copy link
Member

This should be faster in VS Code 1.8, from work in #15384 - try it out and let me know!

@una
Copy link
Author

una commented Dec 20, 2016

It's not much faster for me, just so you know :/

@roblourens
Copy link
Member

Hm, roughly how large is the folder that you're searching in? And how long does it take?

@una
Copy link
Author

una commented Dec 22, 2016

Its really not that big -- 132 files, 578 KB, and takes over 10 seconds on average. Other programs are almost instantaneous

@roblourens
Copy link
Member

Yeah, I would expect that to be searched nearly instantaneously in Code at this point too. Can you check whether other folders are faster, or whether there's something about this particular folder?

@chrmarti chrmarti added this to the January 2017 milestone Feb 21, 2017
@sekkit
Copy link

sekkit commented Jun 5, 2017

In this case, a cache is needed.
Use a datastructure or database to include all text content to speedup text search is possible. Searching file by file is a horrible idea.
I think u can ask Visual Studio team for help.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

7 participants