Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon not displayed for some extensions in side panel #140642

Closed
sbatten opened this issue Jan 13, 2022 · 3 comments
Closed

Icon not displayed for some extensions in side panel #140642

sbatten opened this issue Jan 13, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded workbench-views Workbench view issues
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Jan 13, 2022

Just noticed the current builds changed how the selected Tabbed Container UI option works. It is only displaying the Icon, not the Label anymore.

Version: 1.64.0-insider
Commit: e8a26d3ebf5095d4324ad4bf794787540ed3b33e
Date: 2021-12-21T05:14:12.146Z

But, it is not working correctly for some extensions, like my Bookmarks and Project Manager, neither Microsoft's Live Share.

Kapture Side Panel Icon Issue

Is it something that will be fixed in the Side Panel itself, or extension developers must update their Side Bar icons to be visible there too?

BTW, the icons currently works perfectly in the original Side Bar.

Thank you

Originally posted by @alefragnani in #132893 (comment)

@sbatten sbatten self-assigned this Jan 13, 2022
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues workbench-views Workbench view issues labels Jan 13, 2022
@sbatten sbatten added this to the January 2022 milestone Jan 13, 2022
@sbatten sbatten closed this as completed Jan 13, 2022
@sbatten
Copy link
Member Author

sbatten commented Jan 13, 2022

should be fixed by 8611d26

@sbatten
Copy link
Member Author

sbatten commented Jan 13, 2022

@alefragnani would you mind verifying on your side?

@alefragnani
Copy link

@sbatten confirmed it is working 👍

Tested on build:
Commit: c6e58d1
Date: 2022-01-14T05:16:38.175Z

Thank you

@mjbvz mjbvz added the verified Verification succeeded label Jan 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

3 participants