Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title bar layout control hover state not showing pointer #140724

Closed
miguelsolorio opened this issue Jan 14, 2022 · 6 comments
Closed

Title bar layout control hover state not showing pointer #140724

miguelsolorio opened this issue Jan 14, 2022 · 6 comments
Assignees
@deepak1556 @rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
Electron Integration
Milestone
December / Januar...

Comments

@miguelsolorio
Copy link
Contributor

CleanShot.2022-01-14.at.09.11.50.mp4

When hovering on the layout control in the title bar, I noticed that the hover state did not show the pointer, like the other toolbar hovers. When looking at the css, the properties are properly set:

CleanShot 2022-01-14 at 09 13 35@2x

So I'm kinda stumped why the pointer isn't working. I even testing adding specific css for this and it does not pick it up even though dev tools is showing the right thing.
@sbatten
Copy link
Member

sbatten commented Jan 14, 2022

looks like only repros on macos too :(

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X labels Jan 14, 2022
@sbatten sbatten added this to the January 2022 milestone Jan 14, 2022
@sbatten
Copy link
Member

sbatten commented Jan 21, 2022

This issue appears to be in electron where a div on top of a draggable region using -webkit-app-region: drag will not change its cursor. Here is a gist https://gist.github.com/b1477b2a2658329f9bbb140a899ba26c

@sbatten sbatten assigned deepak1556 and unassigned sbatten Jan 21, 2022
@sbatten sbatten added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jan 21, 2022
@sbatten sbatten removed this from the January 2022 milestone Jan 21, 2022
@sbatten sbatten added the electron Issues and items related to Electron label Jan 21, 2022
@deepak1556 deepak1556 added the confirmed Issue has been confirmed by VS Code Team member label Feb 1, 2022
@deepak1556 deepak1556 added this to the February 2022 milestone Feb 1, 2022
@deepak1556
Copy link
Contributor

thanks for the test case, it helps!

@kieferrm kieferrm mentioned this issue Feb 7, 2022
Closed
81 tasks
@rzhao271 rzhao271 modified the milestones: February 2022, March 2022 Feb 23, 2022
@kieferrm kieferrm mentioned this issue Mar 6, 2022
Closed
87 tasks
@rzhao271 rzhao271 modified the milestones: March 2022, April 2022 Mar 21, 2022
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@rzhao271 rzhao271 modified the milestones: April 2022, May 2022 Apr 22, 2022
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@rzhao271 rzhao271 modified the milestones: May 2022, June 2022 May 25, 2022
@rzhao271 rzhao271 modified the milestones: June 2022, July 2022 Jun 27, 2022
@rzhao271 rzhao271 modified the milestones: July 2022, August 2022 Jul 21, 2022
@deepak1556 deepak1556 removed this from the August 2022 milestone Aug 23, 2022
@deepak1556 deepak1556 added this to Up For Grab in Electron Integration Aug 23, 2022
@rzhao271 rzhao271 added this to the Backlog milestone Dec 6, 2022
@rzhao271 rzhao271 added the titlebar VS Code main title bar issues label Dec 6, 2022
@myabanky

This comment was marked as spam.

Sign in to view
@deepak1556
Copy link
Contributor

Unable to repro with latest insiders, closing as resolved.

@deepak1556 deepak1556 removed this from the Backlog milestone Dec 12, 2023
@rzhao271
Copy link
Contributor

Hm, I can still repro the issue on Monterey. Does that mean this bug depends on the OS version?

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron macos Issues with VS Code on MAC/OS X titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
No open projects
Electron Integration
  
Up For Grab
Milestone
December / January 2024
Development

No branches or pull requests
6 participants
@deepak1556 @sbatten @rzhao271 @miguelsolorio @aiday-mar @myabanky