Jump to line+column in terminal links (format <path> l:c)

[strarsis]

It is possible with VSCode to follow a path printed in the terminal.

When that path also contains the line and column number in the format <path> l:c (l ≙ line number; c ≙ column number),
VSCode currently doesn't interpret it completely and therefore doesn't also jump to the line/column in the opened file.

Example:

resources/styles/blocks/cover/rhombus.scss 49:46

This path format indicates the path to the file but also the line (49) and column (46) number.

Ctrl + clicking this path currently in VSCode will open the file but not jump to the line or the column.

As this format is used by many linters and compilers (e.g. SASS), it would be a very useful and time-saving feature.

[Tyriar]

Code link:

vscode/src/vs/workbench/contrib/terminal/browser/links/terminalValidatedLocalLinkProvider.ts

Lines 35 to 44 in 95a0e2b

	/** As xterm reads from DOM, space in that case is nonbreaking char ASCII code - 160,
	replacing space with nonBreakningSpace or space ASCII code - 32. */
	export const lineAndColumnClause = [
	'((\\S*)[\'"], line ((\\d+)( column (\\d+))?))', // "(file path)", line 45 [see #40468]
	'((\\S*)[\'"],((\\d+)(:(\\d+))?))', // "(file path)",45 [see #78205]
	'((\\S*) on line ((\\d+)(, column (\\d+))?))', // (file path) on line 8, column 13
	'((\\S*):line ((\\d+)(, column (\\d+))?))', // (file path):line 8, column 13
	'(([^\\s\\(\\)]*)(\\s?[\\(\\[](\\d+)(,\\s?(\\d+))?)[\\)\\]])', // (file path)(45), (file path) (45), (file path)(45,18), (file path) (45,18), (file path)(45, 18), (file path) (45, 18), also with []
	'(([^:\\s\\(\\)<>\'\"\\[\\]]*)(:(\\d+))?(:(\\d+))?)' // (file path):336, (file path):336:9
	].join('|').replace(/ /g, `[${'\u00A0'} ]`);

I think here we'd want to require the exact (num)(colon)(num) to prevent problems with (link) (number) (text)

[tjx666]

nice feature for many front end build tools.

[ssigwart]

I added PR #153957 for this.