Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer breaker in contextScopedHistoryWidget.ts #140984

Closed
alexdima opened this issue Jan 19, 2022 · 1 comment
Closed

Layer breaker in contextScopedHistoryWidget.ts #140984

alexdima opened this issue Jan 19, 2022 · 1 comment
Assignees
@connor4312
Labels
*duplicate Issue identified as a duplicate of another issue(s) engineering VS Code - Build / issue tracking / etc.

Comments

@alexdima
Copy link
Member

Code from vs/platform should not import code from vs/editor. Please move the code to vs/editor.

vscode/src/vs/platform/history/browser/contextScopedHistoryWidget.ts

Lines 14 to 15 in 6997390

// eslint-disable-next-line code-import-patterns
import { Context as SuggestContext } from 'vs/editor/contrib/suggest/suggest';

This import came in via a596318 .

(ref #140857 #140874)
@alexdima alexdima added the engineering VS Code - Build / issue tracking / etc. label Jan 19, 2022
@alexdima alexdima mentioned this issue Jan 19, 2022
Closed
@alexdima
Copy link
Member Author

Actually this is a duplicate of #140856

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 19, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
*duplicate Issue identified as a duplicate of another issue(s) engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@connor4312 @alexdima