Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiLinePasteWarning in VSCode terminal，fix the #122683 #141822

Merged
merged 5 commits into from Feb 1, 2022
Merged

Implement multiLinePasteWarning in VSCode terminal，fix the #122683 #141822

merged 5 commits into from Feb 1, 2022

Conversation

weartist
Copy link
Contributor

This PR fixes #122683

Tyriar
Tyriar requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slidoooor, looks great! Just some minor comments

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
src/vs/platform/terminal/common/terminal.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
@Tyriar Tyriar added this to the February 2022 milestone Jan 31, 2022
Tyriar
Tyriar approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @slidoooor, I just made some clean up changes in my last commit.

@Tyriar Tyriar merged commit f6895ac into microsoft:main Feb 1, 2022
@weartist
Copy link
Contributor Author

weartist commented Feb 1, 2022

Thanks for the contribution @slidoooor, I just made some clean up changes in my last commit.

Thank you for helping me improve！

@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@Harry-Hopkinson Harry-Hopkinson Harry-Hopkinson approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

Implement multiLinePasteWarning in VSCode terminal, similar to Windows Terminal behavior
3 participants
@weartist @Tyriar @Harry-Hopkinson