Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased opacity in overload counter tooltip #141828

Merged
merged 3 commits into from Jan 31, 2022
Merged

Conversation

Balastrong
Copy link
Contributor

This PR fixes #137270

The overload counters in the tooltip are difficult to read, in particular in the default dark mode. Increasing the opacity makes it much more readable.

This improves its readability, in particular with the default dark theme.
@gjsjohnmurray
Copy link
Contributor

PR #139963 is already addressing this.

@Balastrong
Copy link
Contributor Author

Balastrong commented Jan 30, 2022

Ah right, I see the user is deleted so maybe it was reasonable going with a new one. I can entirely remove the opacity as suggested by @misolori in the other PR if that makes sense.

@mjbvz mjbvz added this to the February 2022 milestone Jan 31, 2022
@mjbvz mjbvz merged commit 8fc944b into microsoft:main Jan 31, 2022
@mjbvz
Copy link
Contributor

mjbvz commented Jan 31, 2022

Thanks! Yes merging this since the other user seems to have deleted their account

@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The foreground here is very dark, hope we can allow us to modify it ourselves
3 participants