-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user home variable #141902
Add user home variable #141902
Conversation
src/vs/workbench/services/configurationResolver/common/variableResolver.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/configurationResolver/common/variableResolver.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/configurationResolver/common/variableResolver.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/configurationResolver/common/variableResolver.ts
Outdated
Show resolved
Hide resolved
It looks like this change requires knowledge of where the code is running (extension host vs. renderer vs. other processes). I am working on a commit.
vscode/src/vs/server/node/serverServices.ts Line 190 in eb0935b
We should probably move |
@Bruce-Hopkins I have made some changes:
I will test it next week and plan to merge then. |
@alexr00 Thanks. So far it seems to work on my machine. I appreciate the help with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for the PR!
This reverts commit 1a17c0f.
This reverts commit 1a17c0f.
This PR fixes #141657