Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user home variable #141902

Merged
merged 9 commits into from
Feb 7, 2022
Merged

Conversation

Bruce-Hopkins
Copy link
Contributor

This PR fixes #141657

@ghost
Copy link

ghost commented Jan 31, 2022

CLA assistant check
All CLA requirements met.

@alexr00 alexr00 removed this from the February 2022 milestone Feb 3, 2022
@alexr00
Copy link
Member

alexr00 commented Feb 4, 2022

It looks like this change requires knowledge of where the code is running (extension host vs. renderer vs. other processes). I am working on a commit.

I've added the paths to the contructors, now it seems I need to implement the service in instantiationService.ts.

Also, it seems I need to initiate the service in this line. I don't know what method I would do this:

socketServer.registerChannel(REMOTE_TERMINAL_CHANNEL_NAME, new RemoteTerminalChannel(environmentService, logService, ptyService, productService));

We should probably move ExtHostVariableResolverService, which I will do. This releates to knowing which process the code will be running in.

@alexr00
Copy link
Member

alexr00 commented Feb 4, 2022

@Bruce-Hopkins I have made some changes:

  • In places where we're running in a process that can use node (the extension host and the terminal channel process) I have added calls to get the user home with node API.
  • In places where we're not, I use the path service.

I will test it next week and plan to merge then.

@Bruce-Hopkins
Copy link
Contributor Author

@alexr00 Thanks. So far it seems to work on my machine.

I appreciate the help with this PR.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the PR!

@alexr00 alexr00 merged commit 1a17c0f into microsoft:main Feb 7, 2022
@alexr00 alexr00 added this to the February 2022 milestone Feb 7, 2022
meganrogge added a commit that referenced this pull request Mar 4, 2022
meganrogge added a commit that referenced this pull request Mar 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operating system independent home folder variable
2 participants