Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most SyncDescriptorN forms #141976

Merged
merged 2 commits into from Feb 2, 2022
Merged

Remove most SyncDescriptorN forms #141976

merged 2 commits into from Feb 2, 2022

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Feb 2, 2022

From what I can tell, SyncDescriptor0 is the only one of the various SyncDescriptorN types still in use

In order to speed up TS's type checking around createInstance, I think it makes sense to remove the unused forms. We can always introduce them again if we need them again

@mjbvz
Remove most SyncDescriptorX forms
9ab964e 
From what I can tell, `SyncDescriptor0` is the only one of these types still being used. In order to speed up TS's type checking around `createInstance`, I think it makes sense to remove the unused forms
@mjbvz mjbvz added this to the February 2022 milestone Feb 2, 2022
@mjbvz mjbvz self-assigned this Feb 2, 2022
bpasero
bpasero approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jrieken

@alexdima alexdima requested a review from jrieken February 2, 2022 09:05
alexdima
alexdima approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Happy to see these go. They were also difficult for the tree-shaker to understand.

@mjbvz mjbvz merged commit 356d29f into main Feb 2, 2022
@mjbvz mjbvz deleted the dev/mjbvz/remote-most-syncdescX-forms branch February 2, 2022 21:45
@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 2, 2022

Thanks everyone!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@alexdima alexdima alexdima approved these changes

@jrieken jrieken Awaiting requested review from jrieken

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjbvz @bpasero @alexdima