Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: build x64 remote modules with same toolchain as binary #142023

Merged
merged 14 commits into from Feb 3, 2022

Conversation

deepak1556
Copy link
Contributor

@deepak1556 deepak1556 self-assigned this Feb 2, 2022
@deepak1556 deepak1556 added this to the February 2022 milestone Feb 2, 2022
@deepak1556 deepak1556 force-pushed the robo/fix_remote_toolchain_x64 branch 2 times, most recently from 18a1664 to 143b9c1 Compare February 3, 2022 04:32
@deepak1556 deepak1556 marked this pull request as ready for review February 3, 2022 08:37
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@deepak1556
Copy link
Contributor Author

Final dependency chain looks like the following.
Screen Shot 2022-02-03 at 7 01 41 PM

@deepak1556 deepak1556 merged commit b7712c0 into main Feb 3, 2022
@deepak1556 deepak1556 deleted the robo/fix_remote_toolchain_x64 branch February 3, 2022 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Electron 16: linux build failure with remote native modules
3 participants