Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellintegration.ps1 #142217

Merged
merged 7 commits into from Feb 4, 2022
Merged

Fix shellintegration.ps1 #142217

merged 7 commits into from Feb 4, 2022

Conversation

LuanVSO
Copy link
Contributor

@LuanVSO LuanVSO commented Feb 4, 2022

This PR fixes #141764
there's also some general improvements on the script

@Tyriar Tyriar added this to the February 2022 milestone Feb 4, 2022
Tyriar
Tyriar approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍 can clean up the cwd stuff we talked about in the issue later on if needed

@Tyriar Tyriar merged commit 4c65b26 into microsoft:main Feb 4, 2022
@LuanVSO LuanVSO deleted the fix-shellintegration.ps1 branch February 4, 2022 19:55
@LuanVSO LuanVSO mentioned this pull request Feb 4, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

enableShellIntegration issue with custom PowerShell prompt
2 participants
@LuanVSO @Tyriar