New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminal shell integration decorations #142538

Merged

meganrogge merged 42 commits into main from merogge/decorations

Feb 10, 2022

Contributor

meganrogge commented Feb 8, 2022 •

edited

This PR fixes #140308

To do:

add tests
fix input handler for clear upstream
instead of margin left, set width dynamically based on cell size
fix jumpyness
use codicon

meganrogge added 28 commits

January 31, 2022 13:11


          add initial decorations code


          Merge branch 'main' into merogge/decorations

f8d84d4


          add hover css and text

f453170


          pull out into separate method

c53b6a6

try

c20e28d


          improve

2fd9518


          use css class

7adaf3a


          add css

7240de4


          add decorationsAddon

e8124be


          clean up

5c09deb


          add error color

9da35ad


          Merge branch 'main' into merogge/decorations

c831f8a

fix

0a8b1c9


          dispose of decorations on dispose of command detection capability

47fb0c8


          more cleanup

0707aa1


          get it to work

47b2e50


          add colors from theme

e1f8e13


          fix color

98b13dc


          clear when clear is typed

eb776ee


          fix colors


          always return decoration or throw

0eb9a50


          add context menu

a5b4ae7


          get hover and context menu to work

c884b87


          clean up w const enum

a2efe63


          more cleanup

5cfd056


          fix some bugs


          add descriptive hover

94218b6


          clean up

4ad3355

meganrogge self-assigned this

meganrogge added this to the February 2022 milestone

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/decorationAddon.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts Outdated Show resolved Hide resolved

meganrogge commented

View reviewed changes

src/vs/workbench/contrib/terminal/common/terminalColorRegistry.ts Outdated Show resolved Hide resolved


          Merge branch 'main' into merogge/decorations

69ab19b

meganrogge force-pushed the merogge/decorations branch from 1e90518 to 69ab19b Compare

February 10, 2022 18:53

meganrogge added 5 commits

February 10, 2022 12:55


          fix errors

2802b1d


          clean up

0ecbd02


          Update src/vs/workbench/contrib/terminal/browser/xterm/decorationAddo…

91cfedf

…n.ts


          more cleanup

1412c6d


          don't show button if marker is disposed

615587a

This was referenced Feb 10, 2022

set width dynamically based on cell size #142767

Closed

on scroll, decorations jump #142768

Closed

meganrogge merged commit a3b972b into main

meganrogge deleted the merogge/decorations branch

February 10, 2022 21:47

mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this pull request


          Add terminal shell integration decorations (microsoft#142538)

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.