Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the shell integration remote install path resolving #142568

Merged
merged 9 commits into from Feb 15, 2022
Merged

Fix the shell integration remote install path resolving #142568

merged 9 commits into from Feb 15, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 8, 2022 •
edited

Fixes #141599

@Tyriar Tyriar added this to the February 2022 milestone Feb 8, 2022
@Tyriar Tyriar self-assigned this Feb 8, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Feb 9, 2022 •
edited

Looks like this got part of the way there as the server dir is now resolved:

image

Remaining problems:

  • Fix path separators for remote OS
  • Bundle the shell integration scripts with the server
  • Sign .ps1 file to avoid error when using archive (separate issue)
  • Verify

@Tyriar Tyriar changed the title Attempt to fix the remote install path resolving Fix the shell integration remote install path resolving Feb 15, 2022
@Tyriar Tyriar merged commit c2faf99 into main Feb 15, 2022
@Tyriar Tyriar deleted the tyriar/141599 branch February 15, 2022 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

Terminal shell integration doesn't work on remote windows
1 participant
@Tyriar