Update tabs model to utilize the new API shape #142668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
approved these changes
Feb 10, 2022
raghavthind2005
approved these changes
Feb 10, 2022
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Feb 13, 2022
* Change shape of the tabs API * Disable tab tests for now * Add an onDidChangeTabGroup event * Optimize for group activate * Update events to no longer be an array * Further tab optimization
mustard-mh
pushed a commit
to gitpod-io/openvscode-server
that referenced
this pull request
Feb 13, 2022
* Change shape of the tabs API * Disable tab tests for now * Add an onDidChangeTabGroup event * Optimize for group activate * Update events to no longer be an array * Further tab optimization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Microtasking which causes synchronization issues and moves to a more naive algorithm for tab model reconstruction.
@bpasero I left the timers in there for now but I only want to time when log level is set to trace but couldn't figure out how to do that. Should I just take them out and see if the operations are noticeably slow?