Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transition on position for terminal decorations #142847

Closed
Tyriar opened this issue Feb 11, 2022 · 3 comments
Closed

Remove transition on position for terminal decorations #142847

Tyriar opened this issue Feb 11, 2022 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 11, 2022

Looks like the transition is causing the animation when scrolling the terminal:

Recording 2022-02-11 at 06 29 56

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Feb 11, 2022
@Tyriar Tyriar added this to the February 2022 milestone Feb 11, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Feb 11, 2022

Some other notes:

  • The fatter cell-sized rectangle doesn't look great imo, thinner like SCM looks better but it seems like we'll probably move away from that.
  • Using transform scale to increase the size ends up making the square a bit blurry, transitioning via width should fix that.

@meganrogge meganrogge added terminal-shell-integration Shell integration, command decorations, etc. terminal-command-decoration and removed terminal-shell-integration Shell integration, command decorations, etc. labels Feb 11, 2022
@meganrogge
Copy link
Contributor

Going with the codicon and will do the background highlight that we do for other buttons instead of the scale transform

@rchiodo rchiodo added the verified Verification succeeded label Feb 25, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Feb 25, 2022

/verified

@Tyriar Tyriar added the terminal-shell-integration Shell integration, command decorations, etc. label Feb 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@Tyriar @rchiodo @meganrogge and others