New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text buffer memory leak #142933
Comments
I cannot reproduce. Also, the download link to the json file is invalid, you need to pass Note that garbage collection takes some time until unused text models are cleaned up. |
I think a text model that is being disposed when you close an editor is immediately freed from memory if there are no more references. But one thing I remember is that when an extension resolves a text document for any reason, we only free up such a reference after a certain timeout because there is no API to release the use of a text model. So maybe retry with extensions disabled. |
@cynecx I also tried, but failed to reproduce the leakage. However, while investigating I ran into #143111 and #143112 . In the past, in order to be overly careful, when a Looking at your screenshot, I see that there is a reference via v8's deoptimization data left to a disposed |
Same as in #107999.
Steps to Reproduce:
Does this issue occur when all extensions are disabled?: Yes
This is certainly a regression because 1-3 months ago, I haven't noticed this memory leak.
A memory snapshot proves that a reference to the text buffer is still around somewhere:
The text was updated successfully, but these errors were encountered: