Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New notebook 'text/plain' renderers doesn't display line breaks #143194

Closed
tvaucher opened this issue Feb 16, 2022 · 4 comments
Closed

New notebook 'text/plain' renderers doesn't display line breaks #143194

tvaucher opened this issue Feb 16, 2022 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook-output
Milestone

Comments

@tvaucher
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.65.0-insider (commit 52e65499654de7525e30df3a8228b69320796bf5)
  • OS Version: Monterey 12.2

The new text/plain renderer for Notebooks introduced in #142584 (Re #142429) doesn't display line breaks (see attached image). Culprit could be \n within HTML div to represent line breaks in https://github.com/microsoft/vscode/blob/main/extensions/notebook-renderers/src/textHelper.ts instead of < br />? Also breaks for representing long lists.

Thanks for looking into it.

Insiders:
image

Expected (old renderer in 1.64.2):
image

@jaymegordo
Copy link

+1 same issue, very annoying

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-output labels Feb 16, 2022
@rebornix rebornix added this to the February 2022 milestone Feb 16, 2022
@rebornix
Copy link
Member

@tvaucher @jaymegordo thanks for the quick feedback, it should be fixed in tomorrow's Insiders.

image

@amunger
Copy link
Contributor

amunger commented Feb 24, 2022

I'm still seeing \n's from repr output. Panda's series output looks better though
image
Version: 1.65.0-insider (user setup)
Commit: 3112460
Date: 2022-02-24T05:15:20.989Z
Electron: 16.0.9
Chromium: 96.0.4664.174
Node.js: 16.9.1
V8: 9.6.180.23-electron.0
OS: Windows_NT x64 10.0.22000

@rebornix
Copy link
Member

rebornix commented Mar 1, 2022

@amunger this is what you get from jupyter lab too

image

@rebornix rebornix closed this as completed Mar 1, 2022
@rebornix rebornix removed the verification-found Issue verification failed label Mar 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook-output
Projects
None yet
Development

No branches or pull requests

6 participants
@rebornix @amunger @tvaucher @greazer @jaymegordo and others