Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote-cli not being added to PATH with "terminal.integrated.inheritEnv": false #143202

Merged
merged 3 commits into from Feb 17, 2022
Merged

remote-cli not being added to PATH with "terminal.integrated.inheritEnv": false #143202

merged 3 commits into from Feb 17, 2022

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Feb 16, 2022 •
edited

Revives #142740

@alexdima alexdima mentioned this pull request Feb 16, 2022
Merged
@alexdima alexdima added this to the February 2022 milestone Feb 17, 2022
@alexdima alexdima merged commit a998a9c into main Feb 17, 2022
@alexdima alexdima deleted the revert-143201-revert-142740-aeschli/userShellEnvFix branch February 17, 2022 08:32
@aeschli
Copy link
Contributor

aeschli commented Feb 21, 2022

Thanks @alexdima and sorry for the trouble.

@alexdima
Copy link
Member Author

No worries! It was very interesting to find out that it's Path on windows, and not PATH and that process.env is a very special kind of object that works case-insensitive :).

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
February 2022
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexdima @aeschli