get shell integration to work for zsh #143305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Feb 17, 2022
| @@ -273,6 +273,10 @@ export class TerminalProcessManager extends Disposable implements ITerminalProce | |||
| shellLaunchConfig.env = shellLaunchConfig.env || {} as IProcessEnvironment; | |||
| shellLaunchConfig.env['VSCODE_SHELL_LOGIN'] = '1'; | |||
| } | |||
| if (env?.['ZDOTDIR']) { | |||
There was a problem hiding this comment.
I think ?. for here and above isn't actually needed anymore, we should also remove the TODO: fix above
There was a problem hiding this comment.
We may also be able to remove these all together as env is passed into createProcess? See how VSCODE_SHELL_HIDE_WELCOME doesn't need to get set on shellLaunchConfig.env
There was a problem hiding this comment.
see this TODO - slc.env is used, not env in remote terminal backend
src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #141620